ChamberSphere Periodicity Fix#234
Merged
Merged
Conversation
Updated phase_tsys and phase_tdias calculations for elastance values in ChamberSphere
Corrected calculation of S_minus variable in ChamberSphere.cpp (removed "- tdias" shift that was a remnant of original calculation of S_minus) After correcting, plotted ChamberSphere outputs with and without periodic fix.
Prettier binary in node_modules was not executable on Windows filesystem (/mnt/c), so npm run format/check would fail with a shell syntax error. Thus, installed prettier globally and replaced local binary with script that points to global install. Similar fix for clang-format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated phase_tsys and phase_tdias calculations for elastance values in ChamberSphere
Current situation
Improved periodic handling of elastance values during cardiac cycles by updating
phase_tsysandphase_tdiascalculations inChamberSphere.cppto adhere to periodic updates. Without the periodic fix, finite difference spikes, creating discontinuities and/or other abnormal features (see plots attached).Release Notes
phase_tsysandphase_tdiascalculations inChamberSphere.cppby developingwarp_signedfunction.Documentation
Please ensure that you properly document any additions.
Testing
Code of Conduct & Contributing Guidelines